[tor-bugs] #28282 [Core Tor/sbws]: Refactor bandwidth file generation code

Tor Bug Tracker & Wiki blackhole at torproject.org
Thu Nov 1 21:07:47 UTC 2018


#28282: Refactor bandwidth file generation code
--------------------------------------+--------------------------
 Reporter:  juga                      |          Owner:  juga
     Type:  enhancement               |         Status:  assigned
 Priority:  Medium                    |      Milestone:
Component:  Core Tor/sbws             |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:  refactor, technical-debt  |  Actual Points:
Parent ID:                            |         Points:
 Reviewer:                            |        Sponsor:
--------------------------------------+--------------------------
Description changed by juga:

Old description:

> Initially, `v3bwfile.py` was just converting measurement `Result`s to a
> `Bandwidth file` lines format.
> Then we started to apply scaling methods and filtering the measurements
> to satisfy certain restrictions.
> To don not have to modify code in other file/classes, all of that was
> implemented in `v3bwfile.py` classes/methos, but it should be moved to
> either an intermediate file/classes that deal with the statistics
> calculations (and not the format) or modify `Results` to be able to
> perform those calculations.

New description:

 Initially, `v3bwfile.py` was just converting measurement `Result`s to a
 `Bandwidth file` lines format.
 Then we started to apply scaling methods and filtering the measurements to
 satisfy certain restrictions.
 To don not have to modify code in other file/classes, all of that was
 implemented in `v3bwfile.py` classes/methods, but it should be moved to
 either an intermediate file/classes that deal with the statistics
 calculations (and not the format) or modify `Results` to be able to
 perform those calculations.

 Edit: fix typo

--

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28282#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list