[tor-bugs] #26073 [Applications/Tor Browser]: patch tor-browser-build.git for Firefox 60 ESR

[Tor Bug Tracker & Wiki]

#26073: patch tor-browser-build.git for Firefox 60 ESR
--------------------------------------------+------------------------------
 Reporter:  arthuredelstein                 |          Owner:  tbb-team
     Type:  defect                          |         Status:
                                            |  needs_revision
 Priority:  Very High                       |      Milestone:
Component:  Applications/Tor Browser        |        Version:
 Severity:  Normal                          |     Resolution:
 Keywords:  TorBrowserTeam201805, ff60-esr  |  Actual Points:
Parent ID:                                  |         Points:
 Reviewer:                                  |        Sponsor:
--------------------------------------------+------------------------------

Comment (by gk):

 Replying to [comment:41 gk]:
 > Replying to [comment:31 sukhbir]:
 > > {{{
 > > 69874135a6550419f95ef39d41a4e3cc5aa5fa02 -- not needed with the idea
 in commit 81da10daeaa1c35cb78e22006e63f1f86c68a1a8; however now I see as
 the version string:
 > > "tbb-nightly --with-distribution-id=org.torproject --enable-update-
 channel=default --enable-bundled-fonts"
 > > I wonder if that's related to this change or to our tor-browser
 patches...
 > > }}}
 > >
 > > Isn't the string expected given the configuration options we pass? Or
 was there something else before we switched to this?
 >
 > Not really expected. Right now after running the configure step as we do
 in your branch `config.status` shows something like
 > {{{
 >     'TOR_BROWSER_VERSION': '"asan-esr60 --with-distribution-
 id=org.torproject --enable-update-channel=defaut --enable-bundled-fonts"',
 > }}}
 > while we only want to have "asan-esr60" as the version parts.

 Ha, after looking at the `mach` source code it seems to me that `mach
 configure` treats the options as one if they enclosed in quotes. So, doing
 {{{
 ./mach configure --with-tor-browser-version=[% c("var/torbrowser_version")
 %] --with-distribution-id=org.torproject --enable-update-channel=[%
 c("var/torbrowser_update_channel") %] --enable-bundled-fonts
 }}}
 instead should fix this issue...

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26073#comment:42>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online