[tor-bugs] #26073 [Applications/Tor Browser]: patch tor-browser-build.git for Firefox 60 ESR
Tor Bug Tracker & Wiki
blackhole at torproject.org
Tue May 29 08:37:09 UTC 2018
#26073: patch tor-browser-build.git for Firefox 60 ESR
--------------------------------------------+------------------------------
Reporter: arthuredelstein | Owner: tbb-team
Type: defect | Status:
| needs_revision
Priority: Very High | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: TorBrowserTeam201805, ff60-esr | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
--------------------------------------------+------------------------------
Changes (by gk):
* status: needs_review => needs_revision
Comment:
Okay, we are close it seems. Here comes feedback to the latest branch
(`bug-26073-rev1`):
61af9560529c3424e5a6494c6703ebde8591eea9 -- not okay
There is no need to have two `+[% IF c("var/linux") %]` blocks right after
each other, please merge them.
I don't think you need to have "$rootdir/" in either case.
4dc04f54801b6a535a4935af10d42a939086dae5 -- not okay
We should pick up boklm's idea.
Please rebase your final branch against `master`.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26073#comment:40>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list