[tor-bugs] #26073 [Applications/Tor Browser]: patch tor-browser-build.git for Firefox 60 ESR

[Tor Bug Tracker & Wiki]

#26073: patch tor-browser-build.git for Firefox 60 ESR
--------------------------------------------+------------------------------
 Reporter:  arthuredelstein                 |          Owner:  tbb-team
     Type:  defect                          |         Status:  needs_review
 Priority:  Very High                       |      Milestone:
Component:  Applications/Tor Browser        |        Version:
 Severity:  Normal                          |     Resolution:
 Keywords:  TorBrowserTeam201805, ff60-esr  |  Actual Points:
Parent ID:                                  |         Points:
 Reviewer:                                  |        Sponsor:
--------------------------------------------+------------------------------

Comment (by gk):

 Replying to [comment:30 gk]:
 > Replying to [comment:29 gk]:
 > > Replying to [comment:28 gk]:
 > > > e41884c0447cc9c39a466cb5b23ea58dfc48c728 -- not okay
 > > >
 > > > Do we have a lib64 dir for 32bit Linux builds? I somehow doubt that.
 "$rootdir" is not needed (as seen by the tar command we used for cmake
 previously.
 > >
 > > I guess we can test what happens if we get rid of the
 `LD_LIBRARY_PATH` export. If nothing explodes it's not needed (anymore)
 and we can safely omit it.
 >
 > As boklm pointed out, we might just have been lucky in our library
 usage. It's better to fix `LD_LIBRARY_PATH` properly given that we are
 using a non-system GCC.

 Just for the record: the 32bit llvm build does indeed blow up if one uses
 `lib64` instead of `lib`.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26073#comment:33>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online