[tor-bugs] #25156 [Core Tor/Tor]: Stop duplicating static strings between Rust and C

Tor Bug Tracker & Wiki blackhole at torproject.org
Thu May 24 21:18:07 UTC 2018


#25156: Stop duplicating static strings between Rust and C
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  (none)
     Type:  defect                               |         Status:  new
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  unspecified
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.3.2.1-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  rust, memory-leaks, technical-debt,  |  Actual Points:
  034-triage-20180328, 034-removed-20180328      |
Parent ID:                                       |         Points:  1
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by teor):

 If calling into C for strings costs too much CPU, we can generate the
 files at build time.
 Or, if we access the string many times, we can take a copy in Rust.

 Also, duplicating strings costs RAM, so de-duplicating will save us RAM.

 I'm not sure if either effect will be significant in practice.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25156#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list