[tor-bugs] #26183 [Applications/Tor Launcher]: Close control connection (socket and io.streams) on failure

[Tor Bug Tracker & Wiki]

#26183: Close control connection (socket and io.streams) on failure
-------------------------------------------+-------------------
     Reporter:  cypherpunks                |      Owner:  brade
         Type:  defect                     |     Status:  new
     Priority:  Medium                     |  Milestone:
    Component:  Applications/Tor Launcher  |    Version:
     Severity:  Normal                     |   Keywords:
Actual Points:                             |  Parent ID:
       Points:                             |   Reviewer:
      Sponsor:                             |
-------------------------------------------+-------------------
 `_openAuthenticatedConnection` returns `null` connection on failure while
 keeping socket and io.streams open.
 It fails if can't to connect to control port or `authenticate failed`.

 Example log for refused connection:
 {{{
 TorLauncher DBUG: Opening control connection to 127.0.0.1:9151
 TorLauncher DBUG: Sending Tor command: AUTHENTICATE
 5d3a59467366772f65463d6874786b4f
 TorLauncher NOTE: failed to open authenticated connection: [Exception...
 "Component returned failure code: 0x804b000d (NS_ERROR_CONNECTION_REFUSED)
 [nsIBinaryOutputStream.writeBytes]"  nsresult: "0x804b000d
 (NS_ERROR_CONNECTION_REFUSED)"  location: "JS frame :: jar:file:///path
 /tor-browser/Browser/TorBrowser/Data/Browser/profile.default/extensions
 /tor-launcher at torproject.org.xpi!/components/tl-protocol.js ::
 TorProtocolService.prototype._sendCommand :: line 889"  data: no]
 }}}

 About dozen connections in case of very slow starting Tor.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26183>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online