[tor-bugs] #22220 [Core Tor/Tor]: hs: Move cell encoding/decoding out of hs_intropoint.c to hs_cell.c

Tor Bug Tracker & Wiki blackhole at torproject.org
Wed May 23 13:29:04 UTC 2018


#22220: hs: Move cell encoding/decoding out of hs_intropoint.c to hs_cell.c
-------------------------------------------------+-------------------------
 Reporter:  dgoulet                              |          Owner:  neel
     Type:  enhancement                          |         Status:
                                                 |  assigned
 Priority:  Low                                  |      Milestone:  Tor:
                                                 |  unspecified
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-hs, prop224, prop224-extra       |  Actual Points:
  refactor code-movement                         |
Parent ID:                                       |         Points:  0.1
 Reviewer:                                       |        Sponsor:
                                                 |  SponsorR-can
-------------------------------------------------+-------------------------

Comment (by dgoulet):

 I think for this case, a #define macro would be more appropriate. You
 would pass the "get encoded len" fn() and the "do encoding" fn() with
 other things.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22220#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list