[tor-bugs] #26156 [Core Tor/Tor]: Undefined references to EVP_CIPHER_CTX_cleanup() with OpenSSL 1.1.0 no-deprecated

[Tor Bug Tracker & Wiki]

#26156: Undefined references to EVP_CIPHER_CTX_cleanup() with OpenSSL 1.1.0 no-
deprecated
------------------------------+--------------------------------
     Reporter:  laomaiweng    |      Owner:  (none)
         Type:  defect        |     Status:  new
     Priority:  Medium        |  Milestone:
    Component:  Core Tor/Tor  |    Version:  Tor: 0.3.4.1-alpha
     Severity:  Normal        |   Keywords:  openssl
Actual Points:                |  Parent ID:
       Points:                |   Reviewer:
      Sponsor:                |
------------------------------+--------------------------------
 On my machine with OpenSSL 1.1.0 `no-deprecated', Tor 0.3.4.1-alpha fails
 to build. The failure happens when linking several utilities, with the
 following error:

 {{{
 src/common/libor-crypto.a(aes.o): In function `aes_cipher_free_':
 /home/quentin/Security/Code/Tor/tor/src/common/aes.c:121: undefined
 reference to `EVP_CIPHER_CTX_cleanup'
 }}}

 This appears to be due to ''src/common/aes.c'' not #include-ing
 "compat_openssl.h", and thus not having the OPENSSL_1_1_API #define.
 Simply adding {{{#include "compat_openssl.h"}}} in ''aes.c'' fixes the
 build.
 I have also checked that building still succeeds against OpenSSL 1.0.1 and
 1.0.2 with this modification.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26156>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online