[tor-bugs] #26150 [Obfuscation/BridgeDB]: legacy bridge filtering code in bridgedb is suddenly hitting errors

[Tor Bug Tracker & Wiki]

#26150: legacy bridge filtering code in bridgedb is suddenly hitting errors
----------------------------------+--------------------------
 Reporter:  isis                  |          Owner:  isis
     Type:  defect                |         Status:  assigned
 Priority:  Immediate             |      Milestone:
Component:  Obfuscation/BridgeDB  |        Version:
 Severity:  Normal                |     Resolution:
 Keywords:  bridgedb-db           |  Actual Points:
Parent ID:                        |         Points:  1
 Reviewer:                        |        Sponsor:
----------------------------------+--------------------------

Comment (by isis):

 Another similar error:

 {{{
 18:12:57 DEBUG    L325:distributor.getBridges() Client request within time
 interval: 1526925600
 18:12:57 DEBUG    L326:distributor.getBridges() Assigned client to
 subhashring 1/3
 18:12:57 DEBUG    L327:distributor.getBridges() Assigned client to
 subhashring position: 69107a415542eb9381ae06bd4f6defdcf75a03ce
 18:12:57 DEBUG    L328:distributor.getBridges() Total bridges: 1540
 18:12:57 DEBUG    L329:distributor.getBridges() Bridge filters:
 byTransportNotBlockedIn(None,de,4) bySubring1of3
 18:12:57 DEBUG    L333:distributor.getBridges() Cache hit
 frozenset([<function byTransportNotBlockedIn(None,de,4) at
 0x7f267375aed8>, <function bySubring1of3 at 0x7f2678ee9668>])
 18:12:57 DEBUG    L269:distribute.bridgesPerR() Returning 3 bridges from
 ring of len: 508
 18:12:57 DEBUG    L330:Bridges.getBridges()     Got duplicate bridge
 '69d52c45d370ad3ee685206c06c5683aff962d78' in main hashring for position
 '69107a415542eb9381ae06bd4f6defdcf75a03ce'.
 18:12:57 DEBUG    L275:Bridges.filterDistinct() Got 7 possible bridges to
 filter
 18:12:57 ERROR    L862:server.render()          'NoneType' object has no
 attribute '_version'
 Traceback (most recent call last):
 File "/home/bridgedb/virtualenvs/bridgedb/local/lib/python2.7/site-
 packages/bridgedb-0.6.5+0.gd9741cf.dirty-
 py2.7.egg/bridgedb/distributors/https/server.py", line 860, in render
     response = self.getBridgeRequestAnswer(request)
   File "/home/bridgedb/virtualenvs/bridgedb/local/lib/python2.7/site-
 packages/bridgedb-0.6.5+0.gd9741cf.dirty-
 py2.7.egg/bridgedb/distributors/https/server.py", line 904, in
 getBridgeRequestAnswer                                   bridges =
 self.distributor.getBridges(bridgeRequest, interval)
 File "/home/bridgedb/virtualenvs/bridgedb/local/lib/python2.7/site-
 packages/bridgedb-0.6.5+0.gd9741cf.dirty-
 py2.7.egg/bridgedb/distributors/https/distributor.py", line 345, in
 getBridges
     answer = ring.getBridges(position, returnNum, filterBySubnet=True)
   File "/home/bridgedb/virtualenvs/bridgedb/local/lib/python2.7/site-
 packages/bridgedb-0.6.5+0.gd9741cf.dirty-py2.7.egg/bridgedb/Bridges.py",
 line 334, in getBridges
     bridges = self.filterDistinctSubnets(keys)
   File "/home/bridgedb/virtualenvs/bridgedb/local/lib/python2.7/site-
 packages/bridgedb-0.6.5+0.gd9741cf.dirty-py2.7.egg/bridgedb/Bridges.py",
 line 284, in filterDistinctSubnets
     if bridge.address in subnet:
   File "/home/bridgedb/virtualenvs/bridgedb/lib/python2.7/site-
 packages/ipaddr.py", line 637, in __contains__
     if self._version != other._version:
 AttributeError: 'NoneType' object has no attribute '_version'
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26150#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online