[tor-bugs] #26113 [Core Tor/Tor]: Control spec is ambiguous whether a GETCONF error message is specified

Tor Bug Tracker & Wiki blackhole at torproject.org
Tue May 15 21:55:24 UTC 2018


#26113: Control spec is ambiguous whether a GETCONF error message is specified
------------------------------+----------------------------
     Reporter:  dmr           |      Owner:  (none)
         Type:  defect        |     Status:  new
     Priority:  Medium        |  Milestone:
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:  tor-spec, easy
Actual Points:                |  Parent ID:
       Points:                |   Reviewer:
      Sponsor:                |
------------------------------+----------------------------
 The [[https://gitweb.torproject.org/torspec.git/tree/control-
 spec.txt?id=436d08b49fb84aa62d7bc96013002a0c27534bbb#n307|control spec for
 `GETCONF` response]] says:
 {{{
   If some of the listed keywords can't be found, Tor replies with a
   "552 unknown configuration keyword" message.
 }}}

 The spec also has a [[https://gitweb.torproject.org/torspec.git/tree
 /control-spec.txt?id=436d08b49fb84aa62d7bc96013002a0c27534bbb#n1809|clause
 about error messages]]:
 {{{
   Unless specified to have specific contents, the human-readable messages
   in error replies should not be relied upon to match those in this
 document.
 }}}
 Unfortunately, it's unclear what //specified to have specific contents//
 means here. The message for `GETCONF` is quoted, which at least in cursory
 read made me think it was //specified//.
 But I suppose it's ambiguous.

 ==== Expected change
 In discussion over IRC, arma suggested it...
 > might be even better to change the spec to be like "replies with a 552
 message because of the unrecognized configuration key."

 Overall, it was agreed upon amongst arma, meejah, sysrqb, and myself that
 the spec shouldn't be denoting a specific message here, and that
 controllers shouldn't rely on a specific message. Only the numeric code
 `552` should be relied upon.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26113>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list