[tor-bugs] #26040 [Core Tor/Tor]: Improve getrandom handling

Tor Bug Tracker & Wiki blackhole at torproject.org
Mon May 14 21:17:02 UTC 2018


#26040: Improve getrandom handling
--------------------------+------------------------------------
 Reporter:  Hello71       |          Owner:  Hello71
     Type:  enhancement   |         Status:  needs_revision
 Priority:  Medium        |      Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:                |         Points:
 Reviewer:  catalyst      |        Sponsor:
--------------------------+------------------------------------

Comment (by catalyst):

 When thinking about how to describe the user-visible parts of this change,
 I realized that the previous code would loop on `EINTR`, while the patch
 causes a failure and disables `getrandom()` thereafter.  This is unlikely
 to be a problem in practice, because libevent seems to always set
 `SA_RESTART`, which should prevent us from getting `EINTR`.

 Maybe we should mention this in the changes file.  On the other hand,
 maybe the conservative and likely harmless thing to do is to leave the
 existing loop as it is, even if it doesn't ever end up looping.  If we
 restore the loop, I think the remaining parts of the patch are some
 comment improvements and handling of a (also unlikely) short-read
 condition.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26040#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list