[tor-bugs] #26078 [Core Tor/Tor]: CID 1435546: Error handling issues (CHECKED_RETURN)

Tor Bug Tracker & Wiki blackhole at torproject.org
Fri May 11 12:19:51 UTC 2018


#26078: CID 1435546:  Error handling issues  (CHECKED_RETURN)
---------------------------------+------------------------------------
 Reporter:  asn                  |          Owner:  (none)
     Type:  defect               |         Status:  needs_review
 Priority:  Medium               |      Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor         |        Version:
 Severity:  Normal               |     Resolution:
 Keywords:  coverity tor-client  |  Actual Points:
Parent ID:                       |         Points:
 Reviewer:                       |        Sponsor:
---------------------------------+------------------------------------
Changes (by asn):

 * status:  new => needs_review


Comment:

 I have trivial patch that (voids) the retval of `event_del` in my
 `bug26078`.
 I did that because that's also what we do in `mainloop_event_cancel()`.

 I don't think there is much to do apart from that, the only alternative is
 to issue a warn. Let me know if you'd like me to do that.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26078#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list