[tor-bugs] #25943 [Core Tor/Tor]: Investigate and fix tortls/x509_cert_free test failure on win32 CI builds

[Tor Bug Tracker & Wiki]

#25943: Investigate and fix tortls/x509_cert_free test failure on win32 CI builds
--------------------------------------------+------------------------------
 Reporter:  isis                            |          Owner:  (none)
     Type:  defect                          |         Status:  new
 Priority:  Medium                          |      Milestone:
Component:  Core Tor/Tor                    |        Version:  Tor:
                                            |  0.3.3.5-rc
 Severity:  Normal                          |     Resolution:
 Keywords:  tor-ci tor-windows tor-testing  |  Actual Points:
Parent ID:  #25549                          |         Points:  1
 Reviewer:                                  |        Sponsor:
--------------------------------------------+------------------------------

Comment (by nickm):

 If there were no cert member, I think the code wouldn't compile.  The cert
 member is declared here, as the first member of the structure (from
 tortls.h, line 84):
 {{{
 /** Structure that we use for a single certificate. */
 struct tor_x509_cert_t {
   struct x509_st *cert;
   uint8_t *encoded;
   size_t encoded_len;
   unsigned pkey_digests_set : 1;
   common_digests_t cert_digests;
   common_digests_t pkey_digests;
 };

 }}}

 That said, it seems we likely have the right diagnosis.  What if you
 replace the `tor_malloc_zero(sizeof(X509));` with `X509_new()`?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25943#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online