[tor-bugs] #25944 [Core Tor/Tor]: Investigate and fix tortls/context_new test failure on win32 CI builds

[Tor Bug Tracker & Wiki]

#25944: Investigate and fix tortls/context_new test failure on win32 CI builds
--------------------------------------------+------------------------------
 Reporter:  isis                            |          Owner:  (none)
     Type:  defect                          |         Status:  new
 Priority:  Medium                          |      Milestone:
Component:  Core Tor/Tor                    |        Version:  Tor:
                                            |  0.3.3.5-rc
 Severity:  Normal                          |     Resolution:
 Keywords:  tor-ci tor-windows tor-testing  |  Actual Points:
Parent ID:  #25549                          |         Points:  1
 Reviewer:                                  |        Sponsor:
--------------------------------------------+------------------------------

Comment (by saper):

 With additional debug

 {{{
 diff --git a/src/ext/tinytest.c b/src/ext/tinytest.c
 index 3fb1b39c7..b76124462 100644
 --- a/src/ext/tinytest.c
 +++ b/src/ext/tinytest.c
 @@ -142,12 +142,12 @@ testcase_run_forked_(const struct testgroup_t
 *group,
                        " called from within tinytest_main.\n");
                 abort();
         }
 -       if (opt_verbosity>0)
 -               printf("[forking] ");
 -
         snprintf(buffer, sizeof(buffer), "%s --RUNNING-FORKED %s %s%s",
                  commandname, verbosity_flag, group->prefix,
 testcase->name);

 +       if (opt_verbosity>0)
 +               printf("[forking: %s] ", buffer);
 +
         memset(&si, 0, sizeof(si));
         memset(&info, 0, sizeof(info));
         si.cb = sizeof(si);
 @@ -166,8 +166,10 @@ testcase_run_forked_(const struct testgroup_t *group,
                 return OK;
         else if (exitcode == MAGIC_EXITCODE)
                 return SKIP;
 -       else
 +       else {
 +               printf("Exit code: 0x%08lx\n", exitcode);
                 return FAIL;
 +        }
  #else
         int outcome_pipe[2];
         pid_t pid;

 }}}


 tortls/context_new: [forking:
 C:\projects\appveyor\i686-w64-mingw32\src\test\test.exe --RUNNING-FORKED
 tortls/context_new] Exit code: 0xc0000005

 `0xc0000005` in Windows means `ACCESS_VIOLATION` which also means "the
 process has crashed"

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25944#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online