[tor-bugs] #26063 [Core Tor/Tor]: Disable the per-second timer when we can

[Tor Bug Tracker & Wiki]

#26063: Disable the per-second timer when we can
-------------------------------------------------+-------------------------
 Reporter:  nickm                                |          Owner:  nickm
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  High                                 |      Milestone:  Tor:
                                                 |  0.3.4.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-client, 034-roadmap-master,      |  Actual Points:
  034-triage-20180328, 034-included-20180328     |
Parent ID:  #25500                               |         Points:
 Reviewer:  dgoulet                              |        Sponsor:
                                                 |  Sponsor8-must
-------------------------------------------------+-------------------------
Changes (by dgoulet):

 * status:  needs_review => needs_revision


Comment:

 Two comments basically about commit message confusion. Going in
 `needs_revision` just for those but should be `merge_ready` once
 clarified/fixed.

 The rest looks solid to me!

 I'm wondering also once we merge this, we should probably go over the
 `run_scheduled_events()` function and assess all the `net_is_disabled()`
 checks in there. That callback will NOT run if `DisableNetwork` is set so
 that part we can remove but the slight difference is that we use
 `we_are_hibernating()` so technically some of the events in the second
 callback can get called if our hibernation is not "SHUTDOWN". I bet most
 of them shouldn't run...

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26063#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online