[tor-bugs] #26062 [Core Tor/Tor]: client: ControlPort set doesn't mean you're a client

[Tor Bug Tracker & Wiki]

#26062: client: ControlPort set doesn't mean you're a client
---------------------------------------------+-----------------------------
 Reporter:  dgoulet                          |          Owner:  dgoulet
     Type:  defect                           |         Status:
                                             |  needs_review
 Priority:  Medium                           |      Milestone:  Tor:
                                             |  0.3.4.x-final
Component:  Core Tor/Tor                     |        Version:
 Severity:  Normal                           |     Resolution:
 Keywords:  034-roadmap-subtask, tor-client  |  Actual Points:
Parent ID:  #25500                           |         Points:
 Reviewer:  nickm                            |        Sponsor:
---------------------------------------------+-----------------------------
Changes (by dgoulet):

 * keywords:  034-roadmap-subtask => 034-roadmap-subtask, tor-client
 * reviewer:   => nickm
 * status:  assigned => needs_review


Comment:

 See branch `ticket26062_034_01` *ONLY* for 034.

 Following teor's comment from #19665:

  We should split off 59a32e5b4ff210b95bbed294cdc787cb75539da5 into a
 separate ticket and backport it to 0.2.9 and later. Otherwise, relays with
 the control port open will warn based on the client required protocols
 list.


 Here is the 029 branch for the backport and should be merged forward _up_
 to 033: `ticket26062_029_01`. There is a possible very trivial conflict
 since we added `HTTPTunnelPort_set` later on. I'll let that exercise to
 the mergerer :).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26062#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online