[tor-bugs] #25947 [Core Tor/Tor]: Create unit test for dirserv_read_measured_bandwidths

Tor Bug Tracker & Wiki blackhole at torproject.org
Wed May 9 09:25:28 UTC 2018


#25947: Create unit test for dirserv_read_measured_bandwidths
--------------------------+------------------------------------
 Reporter:  juga          |          Owner:  juga
     Type:  enhancement   |         Status:  needs_information
 Priority:  Medium        |      Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  bwauth, test  |  Actual Points:
Parent ID:  #25925        |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------

Comment (by juga):

 > We're waiting on the final spec.

 Even if we go for 2.0.0 (without passing by 1.1.0 first),
 the old format should still be backported, and it does not matter whether
 the additional
 header lines are KeyValue or use SP

 >    ~make a commit with unit tests for the relay lines~

 This is already done by `test_dir_measured_bw_kb`.
 For the test where `node_id` failed to be at the end, it's done in #26004,
 commit dbc80ad19b8a27aab557fe7930e18eef8f415133

 >    ~make a commit that refactors the code so you can test a whole file~

 After nickm pointed how to create temporal files for tests in
 https://trac.torproject.org/projects/tor/ticket/26007#comment:11, this is
 not longer needed

 >    ~make a commit that unit tests a whole torflow file~

 commit in branch `ticket25947_029_squashed`
 https://github.com/juga0/tor/commit/ea0e12ef31c157d43c949dda1469b43704836322

 >    ~make changes to accept the new headers~

 This was technically #25960.

 commit in branch `ticket25947_029_squashed`
 https://github.com/juga0/tor/commit/363cbb4196da91d63c3ff93319911636611018dc

 >    ~make a commit that unit tests a whole sbws file~

 commit in branch `ticket25947_029_squashed`
 https://github.com/juga0/tor/commit/789f794f9fcbc37870e55de3364b3e1dee7dc22a

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25947#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list