[tor-bugs] #25993 [Core Tor/Tor]: Improve deliberate test coverage for addressmap_get_virtual_address()

[Tor Bug Tracker & Wiki]

#25993: Improve deliberate test coverage for addressmap_get_virtual_address()
-------------------------------------------------+-------------------------
 Reporter:  nickm                                |          Owner:  nickm
     Type:  defect                               |         Status:
                                                 |  merge_ready
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.4.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-ci, tor-tests-coverage, tor-     |  Actual Points:
  tests-unit                                     |
Parent ID:  #25908                               |         Points:
 Reviewer:  catalyst                             |        Sponsor:
                                                 |  Sponsor3-can
-------------------------------------------------+-------------------------
Changes (by catalyst):

 * status:  needs_review => merge_ready


Comment:

 Code change look good to me!  I left a comment on GitHub with some
 suggestions about the wording of a comment.

 I haven't fully confirmed that every new test does what it claims to do,
 but it looks likely that the coverage flapping for the .0 and .255 case is
 gone.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25993#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online