[tor-bugs] #25552 [Core Tor/Tor]: prop224: Onion service rev counters are useless and actually harmful for scalability

[Tor Bug Tracker & Wiki]

#25552: prop224: Onion service rev counters are useless and actually harmful for
scalability
-----------------------------------------------+---------------------------
 Reporter:  asn                                |          Owner:  dgoulet
     Type:  defect                             |         Status:
                                               |  needs_revision
 Priority:  Medium                             |      Milestone:  Tor:
                                               |  0.3.4.x-final
Component:  Core Tor/Tor                       |        Version:  Tor:
                                               |  0.3.1.9
 Severity:  Normal                             |     Resolution:
 Keywords:  tor-hs prop224 034-roadmap-master  |  Actual Points:
Parent ID:                                     |         Points:  4
 Reviewer:  asn                                |        Sponsor:
-----------------------------------------------+---------------------------
Changes (by nickm):

 * status:  merge_ready => needs_revision


Comment:

 Travis says the unit tests are failing here.  I confirm:

 {{{
 hs_cache/directory:
   FAIL src/test/test_hs_cache.c:112: expected log to contain "Possible
 descriptor replay detected"  Captured logs:

   [directory FAILED]
 1/1086 TESTS FAILED. (31 skipped)
 }}}

 I'll also start reviewing the branch.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25552#comment:25>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online