[tor-bugs] #25552 [Core Tor/Tor]: prop224: Onion service rev counters are useless and actually harmful for scalability

[Tor Bug Tracker & Wiki]

#25552: prop224: Onion service rev counters are useless and actually harmful for
scalability
-----------------------------------------------+---------------------------
 Reporter:  asn                                |          Owner:  dgoulet
     Type:  defect                             |         Status:
                                               |  needs_review
 Priority:  Medium                             |      Milestone:  Tor:
                                               |  0.3.4.x-final
Component:  Core Tor/Tor                       |        Version:  Tor:
                                               |  0.3.1.9
 Severity:  Normal                             |     Resolution:
 Keywords:  tor-hs prop224 034-roadmap-master  |  Actual Points:
Parent ID:                                     |         Points:  4
 Reviewer:  asn                                |        Sponsor:
-----------------------------------------------+---------------------------

Comment (by dgoulet):

 Ok I've squashed your commit so we can have a clean git history! Your
 github comment doesn't show so I think you forgot to click `Submit review`
 ;).

 All good stuff. Everything is untouched except the
 `hs_descriptor_is_replay()` that I changed so we don't use the
 `hs_descriptor.c` namespace and also I identify the function with `as_dir`
 because the `hs_cache.c` file contains many caches. I'll run this on my
 relay but it will take at the very least 5+ days since takes 96h to get
 HSDir flag ;).

 But I think in the meantime we can merge upstream else we'll be way to
 short from the closing of the merge window here...

 Branch: `ticket25552_034_03`

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25552#comment:23>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online