[tor-bugs] #25997 [Core Tor/Tor]: Solve nondeterminism in testing of hs_get_responsible_hsdirs

[Tor Bug Tracker & Wiki]

#25997: Solve nondeterminism in testing of hs_get_responsible_hsdirs
-------------------------+-------------------------------------------------
     Reporter:  nickm    |      Owner:  nickm
         Type:  defect   |     Status:  assigned
     Priority:  Medium   |  Milestone:  Tor: 0.3.4.x-final
    Component:  Core     |    Version:
  Tor/Tor                |   Keywords:  tor-ci, tor-tests-coverage, tor-
     Severity:  Normal   |  tests-unit
Actual Points:           |  Parent ID:  #25908
       Points:           |   Reviewer:
      Sponsor:           |
-------------------------+-------------------------------------------------
 Only sometimes do our tests call the case of hs_get_responsible_hsdirs
 where it "wraps around":
 {{{
     /* Getting the length of the list if no member is greater than the key
 we
      * are looking for so start at the first element. */
     if (idx == smartlist_len(sorted_nodes)) {
       start = idx = 0;
     }
 }}}

 We should make this consistent.

 I plan to do this, but dgoulet or asn should steal it if they'd rather. :)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25997>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online