[tor-bugs] #25552 [Core Tor/Tor]: prop224: Onion service rev counters are useless and actually harmful for scalability

[Tor Bug Tracker & Wiki]

#25552: prop224: Onion service rev counters are useless and actually harmful for
scalability
-----------------------------------------------+---------------------------
 Reporter:  asn                                |          Owner:  dgoulet
     Type:  defect                             |         Status:
                                               |  needs_review
 Priority:  Medium                             |      Milestone:  Tor:
                                               |  0.3.4.x-final
Component:  Core Tor/Tor                       |        Version:  Tor:
                                               |  0.3.1.9
 Severity:  Normal                             |     Resolution:
 Keywords:  tor-hs prop224 034-roadmap-master  |  Actual Points:
Parent ID:                                     |         Points:  4
 Reviewer:  asn                                |        Sponsor:
-----------------------------------------------+---------------------------
Changes (by dgoulet):

 * status:  assigned => needs_review
 * reviewer:   => asn


Comment:

 Possible branch: `ticket25552_034_01`.

 To be honest, I currently don't see a way for service to stop putting the
 revision counter without breaking many clients because of comment:15.

 Seems like once all HSDir <= 032 are phased out, we can then make the
 service stop putting it in the descriptor (which will break <= 032
 clients...). This means that *right now* (it is in the branch) we have to
 either make the client ignore the revision counter in the secret in put
 construction or always use 0 if no rev counter in the descriptor (which I
 did for simplicity).

 Anyway, see the attempt above.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25552#comment:17>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online