[tor-bugs] #25675 [Core Tor/Tor]: fix CID 1433643

[Tor Bug Tracker & Wiki]

#25675: fix CID 1433643
--------------------------+------------------------------------
 Reporter:  catalyst      |          Owner:  catalyst
     Type:  defect        |         Status:  needs_review
 Priority:  Medium        |      Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor  |        Version:  Tor: 0.2.7.3-rc
 Severity:  Normal        |     Resolution:
 Keywords:  coverity      |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:  Sponsor3
--------------------------+------------------------------------
Changes (by catalyst):

 * status:  assigned => needs_review
 * version:   => Tor: 0.2.7.3-rc
 * sponsor:   => Sponsor3


Old description:



New description:

 Coverity found `control_free_all()` was accessing
 `flush_queued_event_pending` without locking.  This was actually an old
 latent bug dating back to when we added multithreading to this queue, but
 Coverity somehow didn't notice the other unlocked accesses.

--

Comment:

 Patch in https://github.com/torproject/tor/pull/34

 We probably don't need to backport this unless people are trying the
 restart thing in older releases somehow?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25675#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online