[tor-bugs] #24031 [Core Tor/Tor]: Protover.rs could use a better algorithm

[Tor Bug Tracker & Wiki]

#24031: Protover.rs could use a better algorithm
-------------------------------------------------+-------------------------
 Reporter:  nickm                                |          Owner:  isis
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Very High                            |      Milestone:  Tor:
                                                 |  0.3.3.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.3.3.1-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  rust, 033-must, protover, security,  |  Actual Points:  5
  033-triage-20180326, 033-included-20180326     |
Parent ID:                                       |         Points:  1
 Reviewer:  nickm                                |        Sponsor:
                                                 |  SponsorM-can
-------------------------------------------------+-------------------------

Comment (by teor):

 Replying to [comment:24 isis]:
 > One potential difference to the C that I didn't test behaviourally or
 investigate (but it was mentioned in the documentation/comments in a C
 function) was that C tried to use "as few ranges as possible". I think
 that means e.g. `"Foo=1,2"` instead of `"Foo=1-2"`? If so, the Rust does
 the opposite.

 The Rust and C behaviour is currently the same, they both prefer
 "Foo=1-2".
 (I think comment about "as few ranges as possible" refers to merging
 ranges like "Foo=1-2,3-4" into "Foo=1-4".)

 The current authorities produce consensus lines like:

 pr Cons=1-2 Desc=1-2 DirCache=1-2 HSDir=1-2 HSIntro=3-4 HSRend=1-2
 Link=1-5 LinkAuth=1,3 Microdesc=1-2 Relay=1-2

 http://154.35.175.225/tor/status-vote/current/consensus-microdesc

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24031#comment:25>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online