[tor-bugs] #24031 [Core Tor/Tor]: Protover.rs could use a better algorithm

[Tor Bug Tracker & Wiki]

#24031: Protover.rs could use a better algorithm
-------------------------------------------------+-------------------------
 Reporter:  nickm                                |          Owner:  isis
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Very High                            |      Milestone:  Tor:
                                                 |  0.3.3.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.3.3.1-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  rust, 033-must, protover, security,  |  Actual Points:  5
  033-triage-20180326, 033-included-20180326     |
Parent ID:                                       |         Points:  1
 Reviewer:  nickm                                |        Sponsor:
                                                 |  SponsorM-can
-------------------------------------------------+-------------------------
Changes (by isis):

 * status:  needs_revision => needs_review


Comment:

 Replying to [comment:22 isis]:
 > Replying to [comment:21 nickm]:
 > > Also -- could I have this as a github pull request, or failing that,
 as a gitlab pull request?  I'd like to try reviewing this with a UI, since
 the patch series is >3k lines long :)
 >
 > Yep! Will submit to Github? (Wow, this is new.) Should I make an actual
 PR to https://github.com/torproject/tor?

 Okay, more things fixed, it's passing all tests now and I ported all the
 missing tests that we had in C also to the Rust, which found some bugs
 that I fixed, and added more tests to both C and Rust and fixed
 differences in both. [https://travis-
 ci.org/isislovecruft/tor/builds/359555367 Travis passes].

 Branch: `bug24031_r4` (on
 [https://gitweb.torproject.org/user/isis/tor.git/log/?h=bug24031_r4
 git.tpo] or [https://github.com/isislovecruft/tor/tree/bug24031_r4 github]
 PR: https://github.com/torproject/tor/pull/33

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24031#comment:23>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online