[tor-bugs] #25441 [Core Tor/Tor]: Occasional timing? failures in hs_descriptor/validate_cert unit test

[Tor Bug Tracker & Wiki]

#25441: Occasional timing? failures in hs_descriptor/validate_cert unit test
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  (none)
     Type:  defect                               |         Status:  new
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.4.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-hs, rust?, 034-triage-20180328,  |  Actual Points:
  034-removed-20180328                           |
Parent ID:                                       |         Points:  0.5
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by dgoulet):

 We use "now" in the test but `cert_is_valid()` in that test uses
 `approx_time()`. This is also kind of related to #25616 for which one
 solution is to remove that approx time call and instead use the time
 source from the original caller. And this would fix this issue I bet.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25441#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online