[tor-bugs] #21394 [Core Tor/Tor]: connection timeouts are affecting Tor Browser usability

[Tor Bug Tracker & Wiki]

#21394: connection timeouts are affecting Tor Browser usability
-------------------------------------------------+-------------------------
 Reporter:  arthuredelstein                      |          Owner:  (none)
     Type:  defect                               |         Status:
                                                 |  needs_information
 Priority:  Very High                            |      Milestone:  Tor:
                                                 |  0.3.3.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  029-backport, 031-backport, tbb-     |  Actual Points:
  performance, tbb-usability, performance, tbb-  |
  needs, 033-triage-20180320,                    |
  033-included-20180320                          |
Parent ID:                                       |         Points:
 Reviewer:  mikeperry                            |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by mikeperry):

 * status:  needs_review => needs_information


Comment:

 Ok this is a long ticket (with great analysis by all!). I want to clarify
 a few things here to make sure I understand the situation, since this was
 closed and reopened and there was already some confusion about target
 versions.

 Let me know if I get any of this wrong:

 1.
 https://trac.torproject.org/projects/tor/attachment/ticket/21394/bug21394_touch_up.patch
 is the only thing under consideration for merge, and we're targeting it on
 0.3.3. (sha256:
 f81fbbbdae31dcf643ab87feb70386d2209d4c73bc38479d7a4c798a0d51115b since
 attachments can get changed).
 1. That patch sets the "attempts" parameter to 3, since a timeout after 5
 seconds can be retried once more when the connection timeout is 10
 seconds, and twice more when the connection timeout is 15 seconds (on
 retries), totaling 3 attempts in the 15 second case.
 1. We're also raising max-timeouts in the multiple resolver case to be
 more patient with resolvers there, too.

 All of this seems sane to me.

 I have one question, since Dhalgren was concerned about credit. Dhalgren
 -- do you have a preferred name and email address for git for the patch
 (or can you attach a git format-patch with your settings?)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21394#comment:91>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online