[tor-bugs] #24256 [Metrics/Onionoo]: Add a new "outdated" field to distinguish between outdated and too new tor versions

[Tor Bug Tracker & Wiki]

#24256: Add a new "outdated" field to distinguish between outdated and too new tor
versions
-----------------------------+--------------------------------
 Reporter:  arma             |          Owner:  karsten
     Type:  enhancement      |         Status:  needs_revision
 Priority:  Medium           |      Milestone:
Component:  Metrics/Onionoo  |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:                   |  Actual Points:
Parent ID:  #25199           |         Points:
 Reviewer:  iwakeh           |        Sponsor:
-----------------------------+--------------------------------

Comment (by karsten):

 Ah, I see where this is getting. Agreed, there are cases where the current
 implementation is broken. Let's fix it.

 Invalid versions are never recommendable, and we could simply say that
 they are "unrecommended". So, we could change `TorVersion#of` to return
 `null` whenever it is given an invalid tor version.

 And "01.01" should be the same as "1.1".

 I pushed a fixup commit with something that might get us closer to
 completion, though I'm not sure if it resolves all open issues. (I might
 be smarter about this tomorrow, but I ran out of brains for today.)

 Leaving on needs_revision. If you want to revise what's there, feel free!
 Otherwise, I'll take another look tomorrow. Thanks!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24256#comment:26>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online