[tor-bugs] #25264 [Metrics/Website]: Decide what graph to display when there's no data to graph

Tor Bug Tracker & Wiki blackhole at torproject.org
Wed Mar 28 10:52:49 UTC 2018


#25264: Decide what graph to display when there's no data to graph
-----------------------------+------------------------------
 Reporter:  karsten          |          Owner:  iwakeh
     Type:  enhancement      |         Status:  needs_review
 Priority:  Low              |      Milestone:
Component:  Metrics/Website  |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:                   |  Actual Points:
Parent ID:                   |         Points:
 Reviewer:                   |        Sponsor:
-----------------------------+------------------------------
Changes (by iwakeh):

 * status:  accepted => needs_review


Comment:

 I used the attached pictures and pdf.

 Please review [https://gitweb.torproject.org/user/iwakeh/metrics-
 web.git/log/?h=task-25264 this patch branch], which contains one commit
 fixing the usage of StringBuilder.append and a second one implementing the
 wanted functionality.
 The implementation actually catches R errors and makes the respective no-
 data file available instead.  Java can only guess if an R problem
 occurred.  Thus, every call for R-graph generation is now wrapped in an R
 function `robust_call` that creates the no-data objects in case of an
 error.  (`String function = ...` was moved down in order to avoid a
 checkstyle complaint).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25264#comment:18>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list