[tor-bugs] #25659 [Applications/Tor Browser]: Race-condition loading add-ons in Orfox

[Tor Bug Tracker & Wiki]

#25659: Race-condition loading add-ons in Orfox
------------------------------------------+------------------------
     Reporter:  sysrqb                    |      Owner:  tbb-team
         Type:  defect                    |     Status:  new
     Priority:  High                      |  Milestone:
    Component:  Applications/Tor Browser  |    Version:
     Severity:  Normal                    |   Keywords:  tbb-mobile
Actual Points:                            |  Parent ID:
       Points:                            |   Reviewer:
      Sponsor:                            |
------------------------------------------+------------------------
 It seems like there is a race condition when loading add-on at first-
 install/run. We noticed https-everywhere sometimes is not installed after
 freshly installing Orfox.

 Is this a regressions from 52.2.x?

 When https-everywhere is not installed during the first-run after
 installing, the .xpi is copied into <profile_dir>/extensions/staged/ but
 it remains there. Restarting the app does not cause it to be installed.

 However, we found Orfox does install the https-everywhere extension if we
 disable the NoScriptAnywhere (NSA) extensions and then restart the app.

 But it seems NSA is not the cause of this problem because after
 reinstalling the Orfox app (and confirming https-everywhere was not
 installed), we found https-everywhere is installed after toggling
 `extensions.logging.enabled` and then restarting the app. Maybe the extra
 logging slows the app enough.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25659>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online