[tor-bugs] #25581 [Core Tor/Tor]: Inconsistent underscore config options (for vanguard options)

[Tor Bug Tracker & Wiki]

#25581: Inconsistent underscore config options (for vanguard options)
-------------------------------------------------+-------------------------
 Reporter:  atagar                               |          Owner:  nickm
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.3.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Minor                                |     Resolution:
 Keywords:  regression, 033-must,                |  Actual Points:
  033-triage-20180326, 033-included-20180326     |
Parent ID:                                       |         Points:
 Reviewer:  asn                                  |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by mikeperry):

 Hrmm. We discussed this before. The idea was that this would be an
 "expert" option, which we didn't really have before. Hence the single
 underscore. It was a deliberate choice.

 In terms of how risky/"expert" the options actually are compared to other
 things that lack underscores: I also don't see a lot of difference between
 exposing these and letting users do things like EntryNodes {ru}. If we
 think that giving users the ability to set arbitrary values for EntryNodes
 is still acceptable, then I lean in the direction of removing the
 underscore and keeping this public in torrc. We have had issues with
 things like #21155 for EntryNodes, and the risks with _HSLayerKNodes are
 not as severe (basically your service just stops working instead of giving
 away your entry guard node choice).

 In Rome, dgoulet also mentioned that in his experience, HS operators will
 often be reluctant to open their control port, even just for debugging.
 That is another argument for preserving the torrc access of these
 settings.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25581#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online