[tor-bugs] #25386 [Core Tor/Tor]: fix rust tests

[Tor Bug Tracker & Wiki]

#25386: fix rust tests
-------------------------------------------------+-------------------------
 Reporter:  Hello71                              |          Owner:  Hello71
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  High                                 |      Milestone:  Tor:
                                                 |  0.3.4.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.3.3.1-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  rust, tor-test, 033-backport,        |  Actual Points:
  review-group-34                                |
Parent ID:                                       |         Points:  3
 Reviewer:  isis                                 |        Sponsor:
                                                 |  Sponsor8-can
-------------------------------------------------+-------------------------

Comment (by chelseakomlo):

 Replying to [comment:29 Hello71]:
 > I think I agree that libtool is too much work. Possibly we could revisit
 that if we move to a better build system at some point.
 >
 > I think I'll try my wrapper linker solution again and see how it works.
 If that doesn't work out, I'll do the solution where we do CI builds "no
 rust, ubsan + asan", "rust, asan only".
 >
 >  Moreover, eventually it is likely that we will want real
 interdependencies between crates, and I think there is little to no value
 to juggle Rust dependencies when there are no even hypothetical plans to
 embed them in something other than Tor proper all together. I think the
 best solution is to just merge all our Rust crates together, and I've
 filed #25639 to that effect. There may be better solutions, and I'm open
 to suggestions, but it seems to me like that is the only practical one.


 This isn't actually true. For example, we are currently in discussion
 about modularizing tor such that we can have multiple builds (i.e, for
 mobile clients, hidden services, etc). Being able to include/not include
 crates in select builds will be valuable for this effort. Furthermore,
 external projects will be able to leverage this as well, in a way that is
 not currently possible with tor's C code.

 Moving all mode into a single crate is a non-starter for me, as this goes
 against the larger effort of having tor be more modular in the future.

 I would recommend looking at other Rust/C projects such as Gecko, talking
 to some Mozilla people, and thinking through something that both allows
 this functionality as well as enables us to have a clean/modular project
 structure into the future.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25386#comment:30>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online