[tor-bugs] #25432 [Core Tor/Tor]: remove router.c internal functions from router.h

Tor Bug Tracker & Wiki blackhole at torproject.org
Tue Mar 27 12:10:25 UTC 2018

#25432: remove router.c internal functions from router.h
 Reporter:  valentecaio    |          Owner:  valentecaio
     Type:  enhancement    |         Status:  merge_ready
 Priority:  Low            |      Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor   |        Version:
 Severity:  Minor          |     Resolution:
 Keywords:  easy refactor  |  Actual Points:
Parent ID:                 |         Points:
 Reviewer:  asn            |        Sponsor:
Changes (by asn):

 * status:  needs_review => merge_ready


 LGTM! I pushed branch `t-25432` in my github repo (github.com/asn-d6/tor)
 with some basic fixes on the changefile, but other than that it's good!

 Just as a future suggestion, valentecaio, I would ideally make multiple
 commits for such a refactoring project to make review easier. In
 particular, here is how I would structure my branch so that it's easier
 for the reviewer:
 Commit A: Refactor the 4 groupA functions into groupB.
 Commit B: Refactor directory_remove_invalid() to use router_describe().
 Commit C: Misc improvements (move NODE_DESC_BUF_LEN, add docs, etc.)

 All in all, this was a good refactoring! Thanks for the code! :)

Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25432#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

More information about the tor-bugs mailing list