[tor-bugs] #25520 [Metrics/Statistics]: Adapt webstats to read CollecTor provided logs

Tor Bug Tracker & Wiki blackhole at torproject.org
Fri Mar 23 14:12:54 UTC 2018


#25520: Adapt webstats to read CollecTor provided logs
--------------------------------+------------------------------
 Reporter:  iwakeh              |          Owner:  karsten
     Type:  enhancement         |         Status:  needs_review
 Priority:  High                |      Milestone:
Component:  Metrics/Statistics  |        Version:
 Severity:  Normal              |     Resolution:
 Keywords:                      |  Actual Points:
Parent ID:                      |         Points:
 Reviewer:  iwakeh              |        Sponsor:
--------------------------------+------------------------------
Changes (by karsten):

 * status:  needs_revision => needs_review


Comment:

 Replying to [comment:6 iwakeh]:
 > The webstats/MainTest fails.  Maybe, remove or replace by other tests
 (it seems to test log line parsing, which is done in metrics-lib now).

 Hmm, you're right. Everything's tested in metrics-lib, so we can just
 remove this test.

 > Please take a look at [https://gitweb.torproject.org/user/iwakeh
 /metrics-web.git/commit/?h=task-25520 this patch].
 > I tweaked the use of streams a little.  Log line counts could be bigger
 than integer: use long in java and bigint in sql.  If you think that it
 suffices to use int (and don't want to alter the db table) please
 introduce a cast to int at before writing to the db.

 Looks good. I'll alter the database table as part of deployment.

 Please find my updated branch with your commit and with the removed test
 class. I think I'd like to squash all three commits into one, unless you
 think that's a bad idea.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25520#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list