[tor-bugs] #25605 [Core Tor/Tor]: Rust protover::compute_for_old_tor() always says the version is newer than 0.2.9.3-alpha

[Tor Bug Tracker & Wiki]

#25605: Rust protover::compute_for_old_tor() always says the version is newer than
0.2.9.3-alpha
--------------------------------+------------------------------------
 Reporter:  isis                |          Owner:  isis
     Type:  defect              |         Status:  assigned
 Priority:  Medium              |      Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor        |        Version:  Tor: 0.3.3.1-alpha
 Severity:  Normal              |     Resolution:
 Keywords:  033-must, fast-fix  |  Actual Points:
Parent ID:                      |         Points:  1
 Reviewer:                      |        Sponsor:  Sponsor8-can
--------------------------------+------------------------------------
Changes (by isis):

 * priority:  High => Medium


Comment:

 Ohhhh, actually this is just a problem in the test code, this function is
 behaving as we expect it to in C. So the fix is to have the tests call it
 like this `protover::compute_for_old_tor("Tor 0.2.4.20")` instead. I wrote
 some tests for the C in the process.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25605#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online