[tor-bugs] #25560 [Core Tor/Tor]: test all rust crates for realsies

[Tor Bug Tracker & Wiki]

#25560: test all rust crates for realsies
-----------------------------------------+---------------------------------
 Reporter:  isis                         |          Owner:  (none)
     Type:  defect                       |         Status:  needs_revision
 Priority:  High                         |      Milestone:  Tor:
                                         |  0.3.3.x-final
Component:  Core Tor/Tor                 |        Version:  Tor:
                                         |  0.3.3.3-alpha
 Severity:  Normal                       |     Resolution:
 Keywords:  tor-testing, rust, 033-must  |  Actual Points:
Parent ID:                               |         Points:  .2
 Reviewer:  nickm                        |        Sponsor:  SponsorM-can
-----------------------------------------+---------------------------------

Comment (by isis):

 Okay, quoting directories is actually fixed now, I think.  Surprisingly,
 building in directories with spaces in their names was/is already broken,
 because `src/test/include.am` does this:

 {{{
 test-rust:
         $(TESTS_ENVIRONMENT) $(abs_top_srcdir)/src/test/test_rust.sh
 }}}

 which for me expanded to:

 {{{
 export PYTHON="python"; export SHELL="/bin/bash"; export
 abs_top_srcdir="/home/isis/code/torproject/foo bar/../tor"; export
 abs_top_builddir="/home/isis/code/torproject/foo bar"; export
 builddir="."; export TESTING_TOR_BINARY="./src/or/tor"; export
 CARGO="cargo"; export CARGO_ONLINE=""; /home/isis/code/torproject/foo
 bar/../tor/src/test/test_rust.sh
 }}}

 So I've quoted it in the Makefile as well and everything seems to work
 now.

 Let me know if you want me to squash first.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25560#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online