[tor-bugs] #25260 [Applications/Tor Launcher]: Merge mozbuild files into tor-launcher.git

[Tor Bug Tracker & Wiki]

#25260: Merge mozbuild files into tor-launcher.git
---------------------------------------+-----------------------
 Reporter:  sysrqb                     |          Owner:  brade
     Type:  enhancement                |         Status:  new
 Priority:  Medium                     |      Milestone:
Component:  Applications/Tor Launcher  |        Version:
 Severity:  Normal                     |     Resolution:
 Keywords:                             |  Actual Points:
Parent ID:  #24856                     |         Points:
 Reviewer:                             |        Sponsor:
---------------------------------------+-----------------------

Comment (by sysrqb):

 Replying to [comment:11 arthuredelstein]:
 > These patches look good to me in general (though I haven't tested them
 yet). I'm wondering if it's necessary to add moz.build file, or if we
 could still build with the traditional makefile inside torlauncher.git,
 and then just copy the .xpi to the appropriate place when we bundle
 everything together in tor-browser-build.git?

 Unfortunately there are two reasons integrating this into the moz build
 process is useful. The first is because now at packaging-time a manifest
 file is created containing metadata about all system add-ons. If we
 package the xpi separately and copy it into the bundle then rbm will need
 to modify the json file. The second, which is similar to the first, is
 that when we add Android packaging into this build system we'll have
 additional jar manifest files which contain file hashes, so we'll need to
 add/update a few files there, too - so that'll be an additional pain.

 >
 > Keeping the torlauncher and torbutton extension builds independent of
 the Mozilla build system (if possible) seems like it will give us more
 flexibility. For example, I sometimes hack on torbutton.git without having
 a clone of mozilla-central present. I just copy the XPI to an existing Tor
 Browser build. And I occasionally post the .XPI for other people to test.

 This shouldn't have any impact on being able to drop in new versions. The
 system add-on manifest file doesn't prevent modifying the add-on, it
 simply restricts which system add-ons are loaded at start-up (there aren't
 any (cryptographic) hashes associated with it). So, we can build
 everything together and you can update tor-button and tor-launcher XPIs as
 needed afterward. I'm specifically looking for a seamless way of
 integrating these extensions. This probably only buys us 6-12 months of
 legacy support before we need another solution.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25260#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online