[tor-bugs] #25560 [Core Tor/Tor]: test all rust crates for realsies
Tor Bug Tracker & Wiki
blackhole at torproject.org
Tue Mar 20 20:45:37 UTC 2018
#25560: test all rust crates for realsies
------------------------------+-----------------------------------------
Reporter: isis | Owner: (none)
Type: defect | Status: new
Priority: Medium | Milestone:
Component: Core Tor/Tor | Version: Tor: 0.3.3.3-alpha
Severity: Normal | Keywords: tor-testing, rust, 033-must
Actual Points: | Parent ID:
Points: .2 | Reviewer:
Sponsor: SponsorM-can |
------------------------------+-----------------------------------------
After we merged #23881, it seems the tests in the `tor_log` crate aren't
being run because there's an array in `src/test/test_rust.sh` that we
didn't add the crate name to. I propose making that shell script
automatically find the crates available and run their tests, e.g.
{{{#!sh
manifests=`find ${abs_top_srcdir:-.}/src/rust/ -mindepth 2 -maxdepth 2
-name 'Cargo.toml'`
}}}
(Currently, we're only running tests for `crates="protover tor_util
smartlist tor_allocate"`.)
As a side-note, I also think we should be calling cargo with --verbose so
that our test logs actually tell us when something's wrong, e.g. for
#24795 it would help.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25560>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list