[tor-bugs] #19675 [Applications/Tor Browser]: Merge Orfox patches into tor-browser

[Tor Bug Tracker & Wiki]

#19675: Merge Orfox patches into tor-browser
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  igt0
     Type:  task                                 |         Status:  closed
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:  fixed
 Keywords:  tbb-mobile, ff52-esr,                |  Actual Points:
  TorBrowserTeam201803                           |
Parent ID:  #5709                                |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by gk):

 * status:  needs_revision => closed
 * resolution:   => fixed


Comment:

 Alright, we are done here, finally. I did:

 1) Run a build for all supported platforms/architectures to make sure the
 patches don't affect the desktop build
 2) Reviewed the patches
 3) Checked that they are indeed the same patches as in the Orfox
 repository
 4) Built Orfox and ran it successfully on my test phone \o/.

 sysrqb: I wonder if we should amend the "Building Orfox" part on our
 Hacking document a bit to reflect the new situation. FWIW: I needed to
 spent quite some time to get the Android SDK thing to do what it was
 supposed to do, even after calling `./mach bootstrap`. It seems to be the
 case that the bootstrap thing is downloading the r24 SDK, however at the
 end the build-tools r23.0.3 are missing. Trying to install them fails even
 with the SDK manager because I only got offered r23.0.1 and the build
 system is insisting that it needs r23.0.3. So, I ended up just sim-linking
 23.0.1 -> 23.0.3 and that worked smoothly. :) I wonder though whether
 there is something more straightforward we can suggest on the doc...

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19675#comment:21>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online