[tor-bugs] #24256 [Metrics/Onionoo]: Add a new "outdated" field to distinguish between outdated and too new tor versions

[Tor Bug Tracker & Wiki]

#24256: Add a new "outdated" field to distinguish between outdated and too new tor
versions
-----------------------------+------------------------------
 Reporter:  arma             |          Owner:  karsten
     Type:  enhancement      |         Status:  needs_review
 Priority:  Medium           |      Milestone:
Component:  Metrics/Onionoo  |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:                   |  Actual Points:
Parent ID:  #25199           |         Points:
 Reviewer:  iwakeh           |        Sponsor:
-----------------------------+------------------------------
Changes (by karsten):

 * status:  needs_information => needs_review


Comment:

 Replying to [comment:20 iwakeh]:
 > From reading the code I'd say the use of enum 'Status' is good, but
 should be extended, i.e.,
 > instead of private inside the 'TorVersion' helper class use a public
 enum 'Status' that is also used elsewhere and the status String should
 only be used just before serialization.  Using enums more reduces memory
 requirements.

 Are there other places where using these specific "states" (recommended,
 experimental, obsolete, new in series, unrecommended) make any sense? If
 not, let's rather create new enums for those places.

 > The NPE possibly thrown at the beginning of 'TorVersion.of' would stop
 all of the processing.  Is this intended?

 Hmm, probably not. Can you describe a situation (or even better: add a
 test) where this would go wrong?

 Thanks!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24256#comment:21>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online