[tor-bugs] #24256 [Metrics/Onionoo]: Add a new "outdated" field to distinguish between outdated and too new tor versions
Tor Bug Tracker & Wiki
blackhole at torproject.org
Tue Mar 20 10:12:55 UTC 2018
#24256: Add a new "outdated" field to distinguish between outdated and too new tor
versions
-----------------------------+-----------------------------------
Reporter: arma | Owner: karsten
Type: enhancement | Status: needs_information
Priority: Medium | Milestone:
Component: Metrics/Onionoo | Version:
Severity: Normal | Resolution:
Keywords: | Actual Points:
Parent ID: #25199 | Points:
Reviewer: iwakeh | Sponsor:
-----------------------------+-----------------------------------
Changes (by iwakeh):
* status: needs_review => needs_information
Comment:
From reading the code I'd say the use of enum 'Status' is good, but should
be extended, i.e.,
instead of private inside the 'TorVersion' helper class use a public enum
'Status' that is also used elsewhere and the status String should only be
used just before serialization. Using enums more reduces memory
requirements.
The NPE possibly thrown at the beginning of 'TorVersion.of' would stop all
of the processing. Is this intended?
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24256#comment:20>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list