[tor-bugs] #22594 [Metrics/Onionoo]: Escape characters in contact lines break hourly updater

[Tor Bug Tracker & Wiki]

#22594: Escape characters in contact lines break hourly updater
-----------------------------+--------------------------------
 Reporter:  karsten          |          Owner:  iwakeh
     Type:  defect           |         Status:  needs_revision
 Priority:  High             |      Milestone:
Component:  Metrics/Onionoo  |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:  metrics-2018     |  Actual Points:
Parent ID:                   |         Points:
 Reviewer:                   |        Sponsor:
-----------------------------+--------------------------------
Changes (by karsten):

 * status:  needs_review => needs_revision


Comment:

 Looks good! Two things:
  - Can you add a change log entry? Maybe something like this: ''Don't
 attempt to un-escape character sequences in contact lines (like "\uk")
 that only happen to start like escaped utf-8 characters (like "\u0055").''
  - There's similar code where we replace `"\\\\u"` with `"\\u"` in
 `ResponseBuilder`. Does it make sense to use the new method there, too?

 Thanks!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22594#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online