[tor-bugs] #23881 [Core Tor/Tor]: Implement a way to utilise tor's logging system from Rust code

[Tor Bug Tracker & Wiki]

#23881: Implement a way to utilise tor's logging system from Rust code
-------------------------------------------------+-------------------------
 Reporter:  isis                                 |          Owner:  isis
     Type:  enhancement                          |         Status:
                                                 |  needs_revision
 Priority:  High                                 |      Milestone:  Tor:
                                                 |  0.3.3.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  rust, rust-pilot, review-group-29,   |  Actual Points:
  review-group-34                                |
Parent ID:                                       |         Points:  3
 Reviewer:  nickm                                |        Sponsor:
                                                 |  SponsorM-can
-------------------------------------------------+-------------------------
Changes (by nickm):

 * status:  needs_review => needs_revision


Comment:

 When I try to build this, I get some wide-line warnings in torlog.h from
 your d560384fd948ad24625312ee07e04f0cb60ac5b5 .

 Also, I think that d560384fd948ad24625312ee07e04f0cb60ac5b5 is breaking
 the compilation, since I see a bunch of these linker warnings:
 {{{
 src/common/libor-
 event.a(procmon.o):/home/nickm/src/tor/src/common/torlog.h:146: multiple
 definition of `LOG_WARN_'
 src/or/libtor.a(main.o):/home/nickm/src/tor/./src/common/torlog.h:146:
 first defined here
 }}}

 Maybe we should just remove d560384fd948ad24625312ee07e04f0cb60ac5b5 and
 merge the rest?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23881#comment:44>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online