[tor-bugs] #21312 [Obfuscation/Snowflake]: snowflake-client is pegged at 100% cpu

[Tor Bug Tracker & Wiki]

#21312: snowflake-client is pegged at 100% cpu
-----------------------------------+------------------------------
 Reporter:  arlolra                |          Owner:  arlolra
     Type:  defect                 |         Status:  needs_review
 Priority:  High                   |      Milestone:
Component:  Obfuscation/Snowflake  |        Version:
 Severity:  Major                  |     Resolution:
 Keywords:                         |  Actual Points:
Parent ID:                         |         Points:
 Reviewer:                         |        Sponsor:
-----------------------------------+------------------------------

Comment (by yawning):

 Replying to [comment:55 dcf]:
 > About attachment:0001-Add-synchronization-around-destroying-
 dataChannels-a.patch:

 To add to dcf's comments.  There are a few places where you `panic()` with
 the lock held without releasing the lock (eg: the first change in
 `establishDataChannel`.  If a panics bring down the whole program (a la an
 assert), this might be ok, but it feels sloppy to me.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21312#comment:56>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online