[tor-bugs] #25434 [Obfuscation/Snowflake]: Use `ListenAndServeTLS`, not separate `listenTLS` and `Serve` in snowflake-server

Tue Mar 13 23:03:52 UTC 2018

#25434: Use `ListenAndServeTLS`, not separate `listenTLS` and `Serve` in snowflake-
server
-----------------------------------+-----------------------------
 Reporter:  dcf                    |          Owner:  dcf
     Type:  enhancement            |         Status:  merge_ready
 Priority:  Medium                 |      Milestone:
Component:  Obfuscation/Snowflake  |        Version:
 Severity:  Normal                 |     Resolution:
 Keywords:                         |  Actual Points:
Parent ID:                         |         Points:
 Reviewer:                         |        Sponsor:
-----------------------------------+-----------------------------
Changes (by arlolra):

 * status:  needs_review => merge_ready

Comment:

 > This way, we automatically get support for HTTP/2 and whatever TLS
 settings Go configures by default, rather than copy-pasted settings from
 some previous version. The only thing we lose is the ability to run a
 server on port 0; i.e. a random ephemeral port.

 Seems like a reasonable tradeoff to not have to maintain that duplicated
 code.  Patches LGTM.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25434#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online