[tor-bugs] #24735 [Core Tor/Tor]: Always check for the null address when calling address functions

[Tor Bug Tracker & Wiki]

#24735: Always check for the null address when calling address functions
-----------------------------+------------------------------------
 Reporter:  teor             |          Owner:  (none)
     Type:  defect           |         Status:  needs_revision
 Priority:  Medium           |      Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor     |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:  ipv6, tor-relay  |  Actual Points:
Parent ID:  #24403           |         Points:  1
 Reviewer:                   |        Sponsor:  SponsorV-can
-----------------------------+------------------------------------
Changes (by teor):

 * status:  new => needs_revision


Comment:

 Would you like to make those changes as well?

 Also, here is a quick review of your branch:

 Don't add an extra space before the fascist_firewall call.
 Don't add chutney as a submodule.

 There are no IPv6 DirPorts. Please replace the entire pref_dirport
 function with a call to prim_dirport.

 Try to only call each function once in pref_orport. It makes for clearer
 logic.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24735#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online