[tor-bugs] #25245 [Core Tor/Tor]: Crash in assert_connection_ok when changing Exit options

[Tor Bug Tracker & Wiki]

#25245: Crash in assert_connection_ok when changing Exit options
-------------------------------------------------+-------------------------
 Reporter:  toralf                               |          Owner:  (none)
     Type:  defect                               |         Status:  new
 Priority:  Very High                            |      Milestone:  Tor:
                                                 |  0.3.3.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.3.3.2-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  crash, regression?, tor-exit, tor-   |  Actual Points:
  relay, ipv6                                    |
Parent ID:                                       |         Points:  1
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by rl1987):

 I tried untangling the assert statement for better debuggability:
 *
 https://github.com/rl1987/tor/commit/ebd1fda4b16bb169718554e112ede315b9601c61

 Please try reproducing the crash bug with this patch applied. I wasn't
 able to make it crash on my local machine as it seems to be related to
 actual traffic being handled by your relay.

 When exit node feature is disabled by force-reloading torrc, what exactly
 happens to pending exit connections? Do we cancel them properly?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25245#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online