[tor-bugs] #25450 [Core Tor/Tor]: Intermittent test failures for hs_service/service_intro_point

[Tor Bug Tracker & Wiki]

#25450: Intermittent test failures for hs_service/service_intro_point
-------------------------------------------------+-------------------------
 Reporter:  isis                                 |          Owner:  isis
     Type:  defect                               |         Status:
                                                 |  merge_ready
 Priority:  Very High                            |      Milestone:  Tor:
                                                 |  0.3.3.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.3.1.3-alpha
 Severity:  Minor                                |     Resolution:
 Keywords:  tor-unittests review-group-35        |  Actual Points:
  031-backport 032-backport                      |
Parent ID:                                       |         Points:  .5
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor8-can
-------------------------------------------------+-------------------------

Comment (by isis):

 Replying to [comment:5 teor]:
 > I don't think we taught the script to ignore snark.
 >
 > Also, I bet there are a few more sign inversion errors hiding in our
 codebase.

 After a brief foray into parts of the codebase I don't normally touch…
 yes, very likely. More testing! :)

 It seems this test doesn't exist in the `maint-0.3.1` branch, even though
 `git describe b547c542393` tells me it was 0.3.1.3-alpha? It does exist in
 0.3.2, so I've backported to that in my `bug25450_032`
 [https://gitweb.torproject.org/user/isis/tor.git/log/?h=bug25450_032
 branch] ([https://travis-ci.org/isislovecruft/tor/builds/351022882 tests
 pass]).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25450#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online