[tor-bugs] #21003 [Core Tor/Tor]: extend_info_describe should list IPv6 address (if present)

[Tor Bug Tracker & Wiki]

#21003: extend_info_describe should list IPv6 address (if present)
-------------------------------------+----------------------------------
 Reporter:  teor                     |          Owner:  (none)
     Type:  defect                   |         Status:  new
 Priority:  Medium                   |      Milestone:  Tor: unspecified
Component:  Core Tor/Tor             |        Version:
 Severity:  Normal                   |     Resolution:
 Keywords:  easy intro ipv6 logging  |  Actual Points:
Parent ID:                           |         Points:  0.5
 Reviewer:                           |        Sponsor:
-------------------------------------+----------------------------------

Comment (by valentecaio):

 Do you think it would be better to be able to show both addresses?

 By now, the buffer used has space for this output format:
 {{{
 "$FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF~xxxxxxxxxxxxxxxxxxx at
 [ffff:ffff:ffff:ffff:ffff:ffff:255.255.255.255]"
 }}}

 But I think the functions only return strings in one of the following
 formats (please confirm this if you know):
 {{{
 "$FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF~xxxxxxxxxxxxxxxxxxx at
 ffff:ffff:ffff:ffff:ffff:ffff"
 or
 "$FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF~xxxxxxxxxxxxxxxxxxx at
 255.255.255.255"
 }}}

 We could add a separator and show both addresses, something like
 (increasing the buffer size by 2):
 {{{
 "$FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF~xxxxxxxxxxxxxxxxxxx at
 [ffff:ffff:ffff:ffff:ffff:ffff | 255.255.255.255]"
 }}}

 And we could let the caller decide what address it want as output (only
 IPv4, only IPv6 or both), letting "only IPv4" as default.

 What do you think about this?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21003#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online