[tor-bugs] #25425 [Core Tor/Tor]: Add unittests for bridges.c module
Tor Bug Tracker & Wiki
blackhole at torproject.org
Mon Mar 5 21:12:05 UTC 2018
#25425: Add unittests for bridges.c module
---------------------------------------+-----------------------------------
Reporter: isis | Owner: isis
Type: enhancement | Status: needs_review
Priority: Medium | Milestone: Tor:
| 0.3.4.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: tor-unittests, tor-bridge | Actual Points:
Parent ID: | Points: 2
Reviewer: | Sponsor: Sponsor8-can
---------------------------------------+-----------------------------------
Changes (by isis):
* status: accepted => needs_review
* version: Tor: 0.3.3.3-alpha =>
* type: defect => enhancement
* milestone: Tor: 0.3.3.x-final => Tor: 0.3.4.x-final
Comment:
Patch in my `bug25425`
[https://gitweb.torproject.org/user/isis/tor.git/log/?h=bug25425 branch].
It roughly doubles the test coverage of that module.
|| make directive || line coverage || function coverage ||
|| coverage-html || 43.0% || 59.4% ||
|| coverage-html-full || ??? || ??? ||
(The stem tests freeze upon
`test.integ.descriptor.remote.TestDescriptorDownloader` and turn into
three zombie processes on my development machine for some reason that I
didn't bother looking into, so I don't know what `coverage-html-full` will
say.)
I built with `--enable-fatal-warnings --enable-expensive-hardening` and
also ran it under valgrind to check for accidental leaks. Also [https
://travis-ci.org/isislovecruft/tor/builds/349504986 TravisCI passes].
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25425#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list